Do not disconnect from VPN over cellular if security level is medium #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruimarinho
changed the title
ruimarinho
force-pushed
the
bugfix/cellular-disconnect
branch
from
f3fc2f6
to
5b0c19a
Compare
|
@iphoting have you given a thought to this yet? |
|
I don't disagree with your rationale. Just thinking over whether this is considered a "breaking change". What do you think? |
|
According to the README, under the |
|
Ok good point, it’ll be a bug fix. |
ruimarinho
force-pushed
the
bugfix/cellular-disconnect
branch
from
5b0c19a
to
eec3199
Compare
|
Done! |
|
Thanks for catching this! |
iphoting
added a commit
that referenced
this pull request
Sep 10, 2019
v0.7.1 - Bug fix: Do not disconnect from VPN over cellular if security level is medium (#33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this was done in mistake as I don't see a reason for disconnecting over cellular when the security level is medium or higher. At least I would say it's safer if we simply ignore the directive.